Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion from Inf #197

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Fix conversion from Inf #197

merged 3 commits into from
Apr 12, 2024

Conversation

araujoms
Copy link
Contributor

@araujoms araujoms commented Apr 5, 2024

Currently BigFloat(Double64(Inf)) and Float128(Double64(Inf)) return NaN, this PR fixes it.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.95%. Comparing base (c4eef37) to head (f685a21).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   49.95%   49.95%           
=======================================
  Files          63       63           
  Lines        3539     3539           
=======================================
  Hits         1768     1768           
  Misses       1771     1771           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JeffreySarnoff
Copy link
Member

great

@araujoms
Copy link
Contributor Author

Please don't forget this one!

@JeffreySarnoff
Copy link
Member

thanks for the reminder -- when the current new release merges (merge has been requested), I will register this

@araujoms
Copy link
Contributor Author

Now it has merged 😉

@JeffreySarnoff JeffreySarnoff merged commit 47c58ab into JuliaMath:main Apr 12, 2024
7 checks passed
@araujoms
Copy link
Contributor Author

Thanks a lot!

@araujoms araujoms deleted the infnan branch April 12, 2024 13:36
@JeffreySarnoff
Copy link
Member

bumped the patch number, requested new version be merged -- pending
[thank you much for the care and attention]

@JeffreySarnoff
Copy link
Member

JeffreySarnoff commented Apr 12, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants