Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Manifolds.jl to ManifoldsBase 0.13 #468

Merged
merged 278 commits into from
May 10, 2022
Merged

Upgrade Manifolds.jl to ManifoldsBase 0.13 #468

merged 278 commits into from
May 10, 2022

Conversation

kellertuer
Copy link
Member

This PR adapts Manifolds to the new interface introduced in ManifoldsBase.jl 0.13.0

kellertuer and others added 30 commits January 18, 2022 08:57
@kellertuer
Sphere tests work.
6ee23a5
@kellertuer
Lost in Default Metric Dispatch.
33e1ee9
@kellertuer
small fix
7e08006
@kellertuer
Finish Euclidean, cont. Metric.
047e38c
@kellertuer
Adapt Metric Tests further.
0f0fc6c
@kellertuer
move parallel transport to Level 3
2276665
@mateuszbaran
is_default_metric set; and inner forwarding
3e0d98b
@mateuszbaran
Grassmann and Stiefel updates
f7acb6e
@kellertuer
a few minor changes.
bd105db
@kellertuer
A little work on Stiefel.
8a66863
@kellertuer
Fix circle.
d0aa51a
@kellertuer
Update clear preview CI, finish stiefel.
7a20782
@kellertuer
Adapt Grassmann and Elliptope.
b47bb7c
@kellertuer
test IsExplicitDecorator.
e6d1fad
@kellertuer
imports one further function
0af4236
@kellertuer
Merge branch 'short-test' into kellertuer/adapt-to-new-manifoldsbase
30449cb
@kellertuer
finish fixed rank.
eca6707
@kellertuer
Adapt Circle to the new validation scheme.
95d053a
@kellertuer
Fix a typo in sphere.
21c6870
@mateuszbaran
Symmetric update
e40819c
@mateuszbaran
Merge branch 'kellertuer/adapt-to-new-manifoldsbase' of https://githu…
0821dfd 
…b.com/JuliaManifolds/Manifolds.jl into kellertuer/adapt-to-new-manifoldsbase
@kellertuer
reduce check_point and vector.
1aaed51
@kellertuer
Merge branch 'kellertuer/adapt-to-new-manifoldsbase' of github.com:Ju…
ba2f07c 
…liaManifolds/Manifolds.jl into kellertuer/adapt-to-new-manifoldsbase
@kellertuer
fix tests in projective space.
ee7b026
@mateuszbaran
default metric forwarding of some functions and updates to SPD
f07b7d9
@mateuszbaran
forward get_basis through default metric
8dd434c
@mateuszbaran
a bit of work on skew hermitian
69fef8f
@mateuszbaran
vector bundle basis fixes
4092ae8
@mateuszbaran
updates to a few manifolds
b32b3fb
@kellertuer
Invoces in checks are no longer needed.
b7ffbb4
@kellertuer
Copy link
Member Author

Ha. Switching to Julia 1.7 and the codecov v2 upload, we got much closer to out goal (basically we have about 50 lines to cover, still).

@mateuszbaran
Copy link
Member

That's really great! I didn't even know there is a newer codecov upload action.

@kellertuer
Copy link
Member Author

I also just saw that more like by accident.

kellertuer and others added 18 commits May 6, 2022 18:18
@kellertuer
with identity one should not get down to rotations, the case for SO(n…
17fb7b8 
…) is already handled above.
@kellertuer
remove a line that is covered by the default the line before.
281d981
@kellertuer
Increase stats code cov.
f535bb2
@mateuszbaran
some new tests
130c9f5
@mateuszbaran
FiniteDiff and Zygote backends are moved entirely to ManifoldDiff.jl
95adc5a
@mateuszbaran
ForwardDiff and ReverseDiff moved to ManifoldDiff
6a1e2ea
@mateuszbaran
update Riemannian diff
a1bda9f
@mateuszbaran
remove FiniteDiff compat
79c66c5
@mateuszbaran
remove two usings
ae887e1
@mateuszbaran
remove some remaining occurences of ForwardDiff
84ed03c
@kellertuer
Fixes a few broken links in differentiation.md
ec7907e
@mateuszbaran
a few more tests
4196728
@mateuszbaran
one docs change
b303d7f
@mateuszbaran
a couple of Jacobian tests
7e31645
@kellertuer
fixes a few typos and increase test coverage with identity&groups
8ae2084
@kellertuer
Merge branch 'kellertuer/adapt-to-new-manifoldsbase' of github.com:Ju…
76613d2 
…liaManifolds/Manifolds.jl into kellertuer/adapt-to-new-manifoldsbase
@mateuszbaran
more tests
2135a9d
@mateuszbaran
Merge branch 'kellertuer/adapt-to-new-manifoldsbase' of https://githu…
03a9ecd 
…b.com/JuliaManifolds/Manifolds.jl into kellertuer/adapt-to-new-manifoldsbase
kellertuer
kellertuer commented May 10, 2022
View reviewed changes
Copy link
Member Author

@kellertuer kellertuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all the changes again yesterday evening and today, and I am fine with this overall (but I can not approve this since it is my own PR).

mateuszbaran
mateuszbaran approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@mateuszbaran mateuszbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also looked at it and I think this can be merged 👍 .

@kellertuer kellertuer merged commit 01c62dd into master May 10, 2022
@kellertuer kellertuer deleted the kellertuer/adapt-to-new-manifoldsbase branch May 18, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mateuszbaran mateuszbaran mateuszbaran approved these changes

Assignees
No one assigned
Labels
preview docs Add this label if you want to see a PR-preview of the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellertuer @mateuszbaran @dehann