Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle empty input for reval_p #523

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schlichtanders
Copy link

@schlichtanders schlichtanders commented May 2, 2024

if nothing is actually given (like an empty string) this now behaves correctly in returning nothing

fixes #510

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.90%. Comparing base (1517803) to head (61bb39b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   80.40%   77.90%   -2.50%     
==========================================
  Files          26       26              
  Lines        1684     1684              
==========================================
- Hits         1354     1312      -42     
- Misses        330      372      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@palday palday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schlichtanders can you add a test of this behavior?

@schlichtanders
Copy link
Author

@palday yes, please may you point me to the place in the code where you would like to have the test?

@palday
Copy link
Collaborator

palday commented May 16, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: UndefVarError: val not defined
2 participants