Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots and exercises #21

Merged
merged 10 commits into from
Nov 4, 2023
Merged

Plots and exercises #21

merged 10 commits into from
Nov 4, 2023

Conversation

aoanla
Copy link
Collaborator

@aoanla aoanla commented Nov 3, 2023

This is the same stuff as #20 but from a local branch to check it does build with the integrations

Copy link

github-actions bot commented Nov 3, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://JuliaHEP.github.io/JuliaHEP-2023/pr-preview/pr-21/
on branch gh-pages at 2023-11-04 09:43 UTC

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 3, 2023

Hm, all good except apparently jupyterbook really does not like the output of the unicodeplots backend!

@Moelf
Copy link
Member

Moelf commented Nov 3, 2023

yeah if we're rendering notebook we might as well do real plots

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 3, 2023 via email

* Add DataFrames tutorial

First version of a data frames tutorial, covering loading, selecting,
modifying and deriving data
How to handle "missing" values
Some pretty plotting to finish off to show visualisation

Use a reduced Higgs dataset with 50k events as the
full dataset is very large and not needed

* Add more interesting example

Add code to calculate the angular distance between jets and
explore that data

* Add more description

Be more descriptive of what is happening in the visualisation
section. Call out ByRow() as particularly useful.

* Some minor tweaks to the DataFrames

Also rename "chapter 2" to "Additional Topics"
@graeme-a-stewart
Copy link
Member

I do agree that UncodePlots are great - I love them for little fast things in the REPL or CLI, so it's a shame it doesn't work here.

@aoanla - I guess you need to rebase now, after the DataFrame merge

@graeme-a-stewart
Copy link
Member

I think my only additional suggestion here is that you add some L2 headers, so that the page can be more easily navigated from the RHS TOC

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 3, 2023 via email

@aoanla
Copy link
Collaborator Author

aoanla commented Nov 4, 2023

Things I really hate, doing a rebase on something with a Manifest in it

@graeme-a-stewart graeme-a-stewart self-requested a review November 4, 2023 14:43
@graeme-a-stewart
Copy link
Member

Looks good to me - as "Alternatives: Makie.jl" is a L1 header it appears in the LHS menu, but I think this is ok as you can teach all the plotting stuff from the one notebook.

@graeme-a-stewart graeme-a-stewart merged commit eef10b7 into main Nov 4, 2023
2 checks passed
@graeme-a-stewart graeme-a-stewart deleted the plots-and-exercises branch November 4, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants