Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapreduce instead of map + reduce for Jacobians & Hessians #565

Merged
merged 20 commits into from
Oct 10, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Oct 10, 2024

Another partial answer for #563

DI source

DIT source

  • Add function_filter argument to test_differentiation and pass it to JET. On 1.10, it is defined as follows to ignore the warning (not needed on 1.11)
function_filter = @nospecialize(f) -> f != Base.mapreduce_empty

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 56 lines in your changes missing coverage. Please review.

Project coverage is 97.49%. Comparing base (7607ec2) to head (4ca7fa1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tionInterfaceTest/src/tests/type_stability_eval.jl 32.53% 56 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #565      +/-   ##
==========================================
- Coverage   98.00%   97.49%   -0.51%     
==========================================
  Files         108      108              
  Lines        4812     4836      +24     
==========================================
- Hits         4716     4715       -1     
- Misses         96      121      +25     
Flag Coverage Δ
DI 98.66% <100.00%> (-0.01%) ⬇️
DIT 95.20% <34.11%> (-1.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit 9ee81a4 into main Oct 10, 2024
43 checks passed
@gdalle gdalle deleted the gd/mapreduce_typestab branch October 10, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants