add scaling division #666
Merged
add scaling division #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
approved these changes
Feb 20, 2024
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -38,3 +38,6 @@ abstract type AbstractTangent end | |||
| Base.:+(x::AbstractTangent) = x | |||
|
|
|||
| @inline Base.conj(x::AbstractTangent) = x | |||
|
|
|||
| Base.:/(x::AbstractTangent, y) = x * inv(y) | |||
| Base.:\(x, y::AbstractTangent) = inv(x) * y | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| Base.:\(x, y::AbstractTangent) = inv(x) * y | |
| Base.:\(x, y::AbstractTangent) = inv(x) * y |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #666 +/- ##
==========================================
+ Coverage 93.80% 93.81% +0.01%
==========================================
Files 15 15
Lines 985 987 +2
==========================================
+ Hits 924 926 +2
Misses 61 61 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically #660
though I implemented it on AbstractTangent.
Subtraction should be implemented the same.
We already have special cases for this on AbstructThunks, ZeroTangent and NotImplemented.
Potentially the AbstractThunk one could be removed. I don't think the ZeroTangent one could since strong zero