DictoVec: derive from AbstractVector #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add Base.size()
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 86.64% 86.70% +0.05%
==========================================
Files 14 14
Lines 689 692 +3
==========================================
+ Hits 597 600 +3
Misses 92 92
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes R data.frame are constructed such that columns have element names.
RData.jl would then convert these columns into DictoVec object.
However, when converting R data.frame into DataFrames.jl DataFrame object, all column containers are required to support AbstractVector interface.
This PR fixes the failure of DataFrame construction by making DictoVec inherited from AbstractVector and adding necessary methods that are used during DataFrame construction.