updated README to update the after test path to julia bin #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
+ Coverage 90.66% 91.15% +0.48%
==========================================
Files 2 3 +1
Lines 225 226 +1
==========================================
+ Hits 204 206 +2
+ Misses 21 20 -1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fingolfin
reviewed
May 17, 2024
| @@ -198,7 +198,7 @@ When using Coverage.jl locally, over time a lot of `.cov` files can accumulate. | |||
|
|
|||
| ```yml | |||
| after_test: | |||
| - C:\projects\julia\bin\julia -e "using Pkg; Pkg.add(\"Coverage\"); using Coverage; Coveralls.submit(process_folder())" | |||
| - C:\julia\bin\julia -e "using Pkg; Pkg.add(\"Coverage\"); using Coverage; Coveralls.submit(process_folder())" | |||
There was a problem hiding this comment.
I don't know anything about Julia on Windows. What is the current (or past) default install directory ?
There was a problem hiding this comment.
Oh wait, now I realize this is about AppVeyor and in fact a duplicate of PR #329
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous path for the bin folder was giving an error when building. So the documentation now contains the updated path which is compactible.