Fix Coveralls submission, and re-enable Coveralls submission from CI (#…

…315) Co-authored-by: Jameson Nash <[email protected]> Co-authored-by: Jameson Nash <[email protected]>
JuliaCI · Jun 9, 2021 · aa01a30 · aa01a30 · DilumAluthge · Jun 9, 2021
1 parent e0655f8
commit aa01a30
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "Coverage"
 uuid = "a2441757-f6aa-5fb2-8edb-039e3f45d037"
 authors = ["Iain Dunning <[email protected]>", "contributors"]
-version = "1.2.0"
+version = "1.2.1"
 
 [deps]
 CoverageTools = "c36e975a-824b-4404-a568-ef97ca766997"

diff --git a/etc/travis-coverage.jl b/etc/travis-coverage.jl
@@ -1,4 +1,4 @@
 using Coverage
 cov_res = process_folder()
 Codecov.submit(cov_res)
-haskey(ENV, "COVERALLS_URL") && Coveralls.submit(cov_res)
+Coveralls.submit(cov_res)
diff --git a/src/coveralls.jl b/src/coveralls.jl
@@ -43,7 +43,7 @@ module Coveralls
     function to_json(fc::FileCoverage)
         name = Sys.iswindows() ? replace(fc.filename, '\\' => '/') : fc.filename
         return Dict("name"          => name,
-                    "source_digest" => digest(MD_MD5, fc.source, "secret"),
+                    "source_digest" => bytes2hex(digest(MD_MD5, fc.source, "secret")),
                     "coverage"      => fc.coverage)
     end
 
@@ -102,7 +102,7 @@ module Coveralls
             event_path = open(JSON.Parser.parse, ENV["GITHUB_EVENT_PATH"])
             github_pr_info = get(event_path, "pull_request", Dict())
             github_pr = get(github_pr_info, "number", "")
-            isempty(github_pr) || (data["service_pull_request"] = github_pr)
+            isempty(github_pr) || (data["service_pull_request"] = strip(string(github_pr)))
         else
             data["git"] = parse_git_info(git_info)
         end