Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC_preserve coldefs in create_(binary/ascii)_table #31

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Jul 4, 2024

This should ensure that the variable isn't freed while a pointer to it is being used.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.31%. Comparing base (faa9478) to head (6be2bd8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   77.28%   77.31%   +0.03%     
==========================================
  Files           1        1              
  Lines         603      604       +1     
==========================================
+ Hits          466      467       +1     
  Misses        137      137              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 1a398fb into JuliaAstro:master Jul 6, 2024
9 checks passed
@jishnub jishnub deleted the jishnub/pointer_create_table branch July 6, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant