Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix follow_path for objects with start_pos #496

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ArbitRandomUser
Copy link
Contributor

@ArbitRandomUser ArbitRandomUser commented Oct 6, 2022

PR Checklist

If you are contributing to Javis.jl, please make sure you are able to check off each item on this list:

  • Did I update CHANGELOG.md with whatever changes/features I added with this PR?
  • Did I make sure to only change the part of the file where I introduced a new change/feature?
  • Did I cover all corner cases to be close to 100% test coverage (if applicable)?
  • Did I properly add Javis dependencies to the Project.toml + set an upper bound of the dependency (if applicable)?
  • Did I properly add test dependencies to the test directory (if applicable)?
  • Did I check relevant tutorials that may be affected by changes in this PR?
  • Did I clearly articulate why this PR was made the way it was and how it was made?

Link to relevant issue(s)
Closes #
#491

How did you address these issues with this PR? What methods did you use?
the points along which the objects should follow should have object.start_pos subtracted from them.

@ArbitRandomUser ArbitRandomUser marked this pull request as ready for review October 6, 2022 20:04
@codecov-commenter
Copy link

Codecov Report

Merging #496 (b2953ca) into main (1e74392) will decrease coverage by 0.50%.
The diff coverage is 100.00%.

❗ Current head b2953ca differs from pull request most recent head d6e5e78. Consider uploading reports for the commit d6e5e78 to get more accurate results

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
- Coverage   77.74%   77.24%   -0.51%     
==========================================
  Files          38       38              
  Lines        1991     2070      +79     
==========================================
+ Hits         1548     1599      +51     
- Misses        443      471      +28     
Impacted Files Coverage Δ
src/action_animations.jl 95.37% <100.00%> (-0.44%) ⬇️
src/Javis.jl 96.65% <0.00%> (-0.28%) ⬇️
src/Shape.jl 0.00% <0.00%> (ø)
src/backgrounds.jl 100.00% <0.00%> (ø)
src/luxor_utils.jl 100.00% <0.00%> (ø)
src/structs/JPath.jl 100.00% <0.00%> (ø)
src/util.jl 97.36% <0.00%> (+0.05%) ⬆️
src/structs/Frames.jl 96.72% <0.00%> (+0.05%) ⬆️
src/svg2luxor.jl 97.03% <0.00%> (+0.13%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants