-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC'21] Different morphing modes #374
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
=======================================
Coverage 96.25% 96.25%
=======================================
Files 35 35
Lines 1521 1523 +2
=======================================
+ Hits 1464 1466 +2
Misses 57 57
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment here. Let me know when I should do a proper full review
@Wikunia since the goal here is more visual appeal, should we provide some default easing function(apart from linear()) in this PR?? |
I think it makes sense to have the easing separated from the function to have it more composable. The default for all actions should be |
Understood. I was just of the opinion, that in longer running videos it would rather be easy for the user if the small morphs had atleast some visual appeal by default.
Sure yeah. I had thought of that while tackling predefined objects. There are a few things to look into before that. Maybe a macro is handy here. Secondly we can have some predefined actions but at present I still don't know we to wrap around? Would like to hear what ideas you have. |
Let's discuss that tmr in our meeting 😉 |
Self TODO : Check if morphing modes work with #373 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor thing
I feel `floor(Int, ` is cleaner as circshift by a float doesn't make sense
Still not a fan of |
We've decided to call those modes |
CHANGELOG.md
Outdated
@@ -1,5 +1,8 @@ | |||
# Javis.jl - Changelog | |||
|
|||
## Unreleased | |||
- Add a manim-like :long morhping mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated here as well
PR Checklist
If you are contributing to
Javis.jl
, please make sure you are able to check off each item on this list:CHANGELOG.md
with whatever changes/features I added with this PR?Project.toml
+ set an upper bound of the dependency (if applicable)?test
directory (if applicable)?How did you address these issues with this PR? What methods did you use?
This PR introduces some manim like modes for morphing
https://azarzadavila-manim.readthedocs.io/en/latest/animation.html#transform
TEST SCRIPT