Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SliceSampler: simplify code + more detailed errors #183

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

miguelbiron
Copy link
Collaborator

No description provided.

@alexandrebouchard
Copy link
Member

Good idea for the more detailed error, I was just thinking yesterday that would be helpful :)

@miguelbiron
Copy link
Collaborator Author

Thanks! This was inspired by #181 which made me remember when I was debugging the galaxy mixture model.

@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1df9a57) 86.96% compared to head (10476d6) 86.94%.

Files Patch % Lines
ext/PigeonsDynamicPPLExt/interface.jl 50.00% 1 Missing ⚠️
ext/PigeonsDynamicPPLExt/state.jl 75.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   86.96%   86.94%   -0.02%     
==========================================
  Files          95       95              
  Lines        2416     2406      -10     
==========================================
- Hits         2101     2092       -9     
+ Misses        315      314       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miguelbiron miguelbiron merged commit 77b8f35 into main Nov 24, 2023
10 checks passed
@miguelbiron miguelbiron deleted the ss-handle-inf-z branch November 24, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants