Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COMPOSE] Share fragment #1

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

[COMPOSE] Share fragment #1

wants to merge 19 commits into from

Conversation

JuancaG05
Copy link
Owner

@JuancaG05 JuancaG05 commented May 30, 2022

ShareFileFragment moved to Jetpack Compose


QA

Sharing

Device: Pixel5, Android12

Server: 10.10.0

Base commit: f7c4c997 (compose_shares)

Authentication: Basic auth


Test Case Description Expected Result Comment
Private Share  
Shared with one user Select to share a file whose name contains special characters with a user whose name includes special characters Check that user2 has access to the file
Check that the file includes the individual share icon
Shared with one group Select to share a file with a group whose name includes special characters Check that everyone in the group has access to the file
Check that the file includes the group share icon
Shared with several Select to share a file with several users and groups Check that every sharee has access to the file
Check that the shares includes the correct individual/group icon
Share with users + Share with link 1. Select an item to share with several users
2. Select same item to share by link, creating several links
Check that the link works
Check, at least one user have still access to the file
Federated Share Share a folder with a user in other server (reachable) Check that the user can see the file in the list
Edit 1. Previously shared item with a user
2. Click on the pencil icon to edit
3. Remove permissions
Check in server that the share does not have any permissions
Delete 1. Previously shared item with several users
2. Unshare one of the sharees
The share with individual icon is no longer displayed
User does not have access to the folder any more
Other shares do not change
Delete all Delete all sharees form an item Empty list of shares
Public Share  
Share by link 1. Share a item by link
2. Access using a web browser to the link
1. Link is generated and options to share are shown
2. Link works
Unshare by link Select to unshare the previous file Link icon is not shown. Link doesn't work
Multiple links Create several public links on the same item Check that all of them are correctly generated in server
Edit 1. Links created before
2. Click on the pencil icon to edit
3. Add password and expiration date
Check in server that the link has the correct expiration date and password
Remove links After creating a huge amount of links in the same file, remove some of them Check in server that removed links do not appear anymore
Remove all links After creating a huge amount of links in the same file, remove all of them Empty list of links
Capabilities  
Server doesn't support share api 1. In server, select to disable the share API
2. From the app, try to share a file/folder
Sharing option does not appear, only private link.
Server doesn't support public links 1. In sever, select to disable the public link API
2. From the app, try to share by link a file/folder
Only private link and private share
Extra field = None Set extra field = none
Create private share
Results do not show nothing extra
Extra field = User ID Set extra field = User ID
Create private share
User ID is shown in results
Extra field = Email Set extra field = Email
Create private share
Email is shown in results

@JuancaG05 JuancaG05 requested a review from abelgardep May 30, 2022 13:36
@JuancaG05 JuancaG05 self-assigned this May 30, 2022
Copy link
Collaborator

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge work @JuancaG05 💯

I left some suggestions! Let me know what you think about them! 🍻

@JuancaG05 JuancaG05 requested a review from abelgardep May 31, 2022 10:26
Copy link
Collaborator

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants