forked from owncloud/android
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COMPOSE] Share fragment #1
Open
JuancaG05
wants to merge
19
commits into
master
Choose a base branch
from
compose/shares
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelgardep
requested changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge work @JuancaG05 💯
I left some suggestions! Let me know what you think about them! 🍻
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Show resolved
Hide resolved
...main/java/com/owncloud/android/presentation/ui/sharing/fragments/ShareFileComposeFragment.kt
Outdated
Show resolved
Hide resolved
abelgardep
approved these changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShareFileFragment
moved to Jetpack ComposeQA
Sharing
Device: Pixel5, Android12
Server: 10.10.0
Base commit:
f7c4c997
(compose_shares)Authentication: Basic auth
Check that the file includes the individual share icon
Check that the file includes the group share icon
Check that the shares includes the correct individual/group icon
2. Select same item to share by link, creating several links
Check, at least one user have still access to the file
2. Click on the pencil icon to edit
3. Remove permissions
2. Unshare one of the sharees
User does not have access to the folder any more
Other shares do not change
2. Access using a web browser to the link
2. Link works
2. Click on the pencil icon to edit
3. Add password and expiration date
2. From the app, try to share a file/folder
2. From the app, try to share by link a file/folder
Create private share
Create private share
Create private share