-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require stake for add opening #2256
Require stake for add opening #2256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left several comments related to:
- unwrap()
- OpeningStake changes between add_opening() and fill_opening (or cancel opening()) extrinsics.
- constant renaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please, fix the merge conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Regarding #2196 for
add_opening
In this comment we decided that the best way to deal with a lead creating a lot of openings to fill the storage is to have it require an additional stake, which additionally to prevent an attack filling the storage also motivates the lead to cleanup any lingering opening.
Fix Joystream/audits#12