Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require stake for add opening #2256

Merged
merged 2 commits into from
Mar 29, 2021
Merged

Require stake for add opening #2256

merged 2 commits into from
Mar 29, 2021

Conversation

conectado
Copy link
Contributor

@conectado conectado commented Mar 17, 2021

Regarding #2196 for add_opening

In this comment we decided that the best way to deal with a lead creating a lot of openings to fill the storage is to have it require an additional stake, which additionally to prevent an attack filling the storage also motivates the lead to cleanup any lingering opening.

Fix Joystream/audits#12

Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left several comments related to:

  • unwrap()
  • OpeningStake changes between add_opening() and fill_opening (or cancel opening()) extrinsics.
  • constant renaming

runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
runtime-modules/working-group/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please, fix the merge conflicts.

@shamil-gadelshin shamil-gadelshin merged commit dd37cac into Joystream:olympia Mar 29, 2021
Copy link
Contributor

@shamil-gadelshin shamil-gadelshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants