Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

☎️ Query the new notifications from Orion #4868

Merged
merged 40 commits into from
Nov 2, 2023
Merged

☎️ Query the new notifications from Orion #4868

merged 40 commits into from
Nov 2, 2023

Conversation

thesan
Copy link
Collaborator

@thesan thesan commented Sep 14, 2023 •
edited
Loading

> Story
> Preview
> QA
> Designs

Still to do:

  • List missing data
  • Filter by channel
  • Open video page with NFT widget
  • Open switch channel widget

@thesan thesan requested review from attemka and WRadoslaw September 14, 2023 07:14
thesan added 20 commits September 14, 2023 14:24
@thesan
Add the membership and channel notifications queries
501a6e6
@thesan
Add the MarkNotificationsAsRead mutation
fdd8a12
@thesan
Update the NotificationRecord type
8c0067f
@thesan
Rename the notifications query results
84ac0a9
@thesan
Remove markNotificationsAsUnread
7ab946b
@thesan
Switch to channel notification when in studio
066356d
@thesan
Add the new notifications text
9b5b8c4
@thesan
Prepare the avatar data
4aa9655
@thesan
Add links and icons
dc28613
@thesan
Move icon mapper and getNotificationUX into a utils file
e15c768
@thesan
Add the useNotificationAvatar hook
59e2cf4
@thesan
Handle notification actions by types
2328aea
@thesan
Rename NotificationTile.hooks.tsx
1b9151e
@thesan
Fix the NotificationTile story
22d5a9c
@thesan
Set the notification settings links
8786971
@thesan
Rename the channel settings hook
0fef2f8
@thesan
Fix notifications
d19f1ba
@thesan
Rely on Orion to differentiate member from channel notifications
dd1174e
@thesan
Fix some UI issues
f9b9a18
@thesan
Fix the last seen notification logic
eeef2c5
@thesan thesan force-pushed the feature/orion-notifications branch from 2153f0d to eeef2c5 Compare September 14, 2023 14:40
@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
atlas ✅ Ready (Inspect) Visit Preview Oct 3, 2023 0:38am
atlas-storybook ✅ Ready (Inspect) Visit Preview Oct 3, 2023 0:38am
1 Ignored Deployment
Name Status Preview Updated (UTC)
atlas-staging ⬜️ Ignored (Inspect) Oct 3, 2023 0:38am

attemka
attemka requested changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@attemka attemka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous work! some minor code stuff. I'll do some e2e and will post here if I'll find smth

packages/atlas/src/components/_notifications/NotificationTile/NotificationTile.hooks.tsx Outdated Show resolved Hide resolved
packages/atlas/src/components/_notifications/NotificationTile/NotificationTile.hooks.tsx Outdated Show resolved Hide resolved
packages/atlas/src/components/_notifications/NotificationTile/NotificationTile.hooks.tsx Outdated Show resolved Hide resolved
packages/atlas/src/components/_overlays/MemberDropdown/MemberDropdownList.tsx Outdated Show resolved Hide resolved
@thesan thesan requested a review from attemka October 25, 2023 11:14
@thesan thesan mentioned this pull request Oct 31, 2023
Merged
@attemka attemka merged commit a751b91 into Joystream:notifications Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignazio-bovo ignazio-bovo ignazio-bovo left review comments

@attemka attemka attemka approved these changes

@WRadoslaw WRadoslaw Awaiting requested review from WRadoslaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thesan @ignazio-bovo @attemka