Removed encoding check for non-video assets (#4899)

Joystream · Sep 20, 2023 · bb2f469 · bb2f469
1 parent 6f96219
commit bb2f469
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/atlas/src/hooks/useGetAssetUrl.ts b/packages/atlas/src/hooks/useGetAssetUrl.ts
@@ -39,10 +39,19 @@ export const getSingleAssetUrl = async (
       return distributionAssetUrl
     } catch (err) {
       if (err instanceof MediaError) {
-        const codec = getVideoCodec(distributionAssetUrl)
-        UserEventsLogger.logWrongCodecEvent(eventEntry, { codec })
+        let codec = ''
+        if (type === 'video') {
+          codec = getVideoCodec(distributionAssetUrl)
+        }
+        UserEventsLogger.logWrongCodecEvent(eventEntry, { assetType: type, ...(type === 'video' ? { codec } : {}) })
         SentryLogger.error('Error during asset download test, media is not supported', 'AssetsManager', err, {
-          asset: { parent, distributionAssetUrl, mediaError: err, codec },
+          asset: {
+            parent,
+            distributionAssetUrl,
+            mediaError: err,
+            assetType: type,
+            ...(type === 'video' ? { codec } : {}),
+          },
         })
       }
     }

diff --git a/packages/atlas/src/utils/logs/asset.ts b/packages/atlas/src/utils/logs/asset.ts
@@ -51,6 +51,7 @@ export type DistributorEventEntry = {
 } & DistributorEventDetails
 
 type CodecInfo = {
+  assetType: string | null
   codec?: string
 }