🆙 Sign up and sentry improvements (#4908)

* Avoid overriding main error with context values * Make sure to do not use error as key for senty log context * Close signup modal on faucet error
Joystream · Sep 21, 2023 · 0c41bc2 · 0c41bc2
1 parent 43aab28
commit 0c41bc2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/packages/atlas/src/components/_auth/SignUpModal/SignUpModal.tsx b/packages/atlas/src/components/_auth/SignUpModal/SignUpModal.tsx
@@ -7,7 +7,7 @@ import { useGetMembershipsLazyQuery } from '@/api/queries/__generated__/membersh
 import { Button } from '@/components/_buttons/Button'
 import { DialogButtonProps } from '@/components/_overlays/Dialog'
 import { DialogModal } from '@/components/_overlays/DialogModal'
-import { AccountFormData, FaucetError, MemberFormData, RegisterError, useCreateMember } from '@/hooks/useCreateMember'
+import { AccountFormData, MemberFormData, RegisterError, useCreateMember } from '@/hooks/useCreateMember'
 import { useMediaMatch } from '@/hooks/useMediaMatch'
 import { useSegmentAnalytics } from '@/hooks/useSegmentAnalytics'
 import { useUniqueMemberHandle } from '@/hooks/useUniqueMemberHandle'
@@ -214,12 +214,8 @@ export const SignUpModal = () => {
         onStart: () => {
           goToStep(SignUpSteps.Creating)
         },
-        onError: (error) => {
-          if (error === FaucetError.MemberAlreadyCreatedForGoogleAccount) {
-            setAuthModalOpenName(undefined)
-          } else {
-            goToStep(SignUpSteps.CreateMember)
-          }
+        onError: () => {
+          setAuthModalOpenName(undefined)
         },
       })
       if (memberId) {

diff --git a/packages/atlas/src/components/_inputs/MultiFileSelect/MultiFileSelect.tsx b/packages/atlas/src/components/_inputs/MultiFileSelect/MultiFileSelect.tsx
@@ -195,7 +195,7 @@ export const MultiFileSelect: FC<MultiFileSelectProps> = memo(
       } else if (errorCode === 'file-too-large') {
         setError('File too large')
       } else {
-        SentryLogger.error('Unknown file select error', 'MultiFileSelect', null, { error: { code: errorCode } })
+        SentryLogger.error('Unknown file select error', 'MultiFileSelect', null, { parsedError: { code: errorCode } })
         setError('Unknown error')
       }
     }, [])

diff --git a/packages/atlas/src/hooks/useCreateMember.ts b/packages/atlas/src/hooks/useCreateMember.ts
@@ -146,7 +146,9 @@ export const useCreateMember = () => {
 
         const errorCode = isAxiosError<NewMemberErrorResponse>(error) ? error.response?.data?.error : null
 
-        SentryLogger.error('Failed to create a membership', 'SignUpModal', error, { error: { errorCode } })
+        SentryLogger.error(`Failed to create a membership ${ytResponseData ? 'YPP' : ''}`, 'SignUpModal', error, {
+          parsed: { errorCode },
+        })
 
         switch (errorCode) {
           case 'TooManyRequestsPerIp':

diff --git a/packages/atlas/src/utils/logs/sentry.ts b/packages/atlas/src/utils/logs/sentry.ts
@@ -104,8 +104,8 @@ class _SentryLogger {
 
     Sentry.captureException(new SentryError(title, message), {
       contexts: {
-        error,
         ...contexts,
+        error,
       },
       tags,
       user: { ...this.user, ip_address: '{{auto}}' },