Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
JosephTLyons committed Nov 20, 2024
1 parent 766b117 commit 65b66a9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

## v1.3.5 - 2024-11-19

TODO

- Fixed bug with parsing base prefix strings later in the string
- Fixed bug with base 0 and no prefix would still parse
- Fixed a bug where base prefix substrings would be recognized as such later in the string.
- The `0b` in `0XDEAD_BEEF0b` should be catorgized as digits and not a base prefix.
- Fixed a bug where, in base 0 mode, `lenient_parse` would parse a string with an incomplete base prefix.
- `01` should reject, as it is missing a specifier (`b`, `B`, `o`, `O`, `x`, `X`).

## v1.3.4 - 2024-11-19

Expand Down
3 changes: 0 additions & 3 deletions src/lenient_parse/internal/parser.gleam
Original file line number Diff line number Diff line change
Expand Up @@ -231,9 +231,6 @@ fn parse_sign(
}
}

// TODO: Clean up the index range vs start and end index stuff here
// TODO: Delete {}s in case
// TODO: Clean up new_rest duplication
fn parse_base_prefix(
tokens tokens: List(Token),
index index: Int,
Expand Down
2 changes: 0 additions & 2 deletions test/tokenizer_test.gleam
Original file line number Diff line number Diff line change
Expand Up @@ -437,5 +437,3 @@ pub fn tokenize_int_with_all_whitespace_characters_test() {
|> tokenizer.tokenize_int
|> expect.to_equal(expected_tokens)
}
// TODO: all tokenizer tests and see what isn't needed now that base prefix
// logic isn't happening here

0 comments on commit 65b66a9

Please sign in to comment.