Allow to execute actions on gesture begin and end #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a boolean, use an enum to allow to add more values in the future. Refactor, no functional changes.
Allow to run SEND_KEYS, RUN_COMMAND and MOUSE_CLICK actions on gesture begin and on gesture end.
Instead of sending mouse clicks as an atomic action, split them for better control. Refactor, no functional changes.
When the `begin-and-end` option is used, the mouse button is down when the gesture begins and up when the gesture ends.
To allow custom scripts to know if the command is ran when the gesture begins, updates or ends, set a environment variable.
|
It doesn't work; I'd like a new "drag" gesture type. Even if the button is held down, the click position is in the same place, not where the cursor is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, it was only possible to execute the
MOUSE_CLICK,SEND_KEYSandRUN_COMMANDactions when the gesture started or when the gesture ended.Include a third option,
<on>begin-and-end</on>allowing to run the actions both when the gesture starts and ends.When this new setting is used,
MOUSE_CLICKstarts presses the mouse button when the gesture starts and releases it when the gesture ends.In the case of
RUN_COMMAND, a environment variable is set (TOUCHEGG_GESTURE_ON) allowing the executed script to take different actions at the beginning and the end of the gesture.Closes: #665