#834 on dev #845
Open
#834 on dev #845
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2025 14:51
Firefox addons need to have a unique add-on ID. The add-on ID is specified via `browser_specific_settings.gecko.id` in the manifest. #616 consistently set the add-on ID to "[email protected]", which won't work for anyone else who wants to publish an add-on. Make the add-on ID configurable via the core manifest.js, since chrome extensions don't seem to care about the extra manifest key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Priority*
Purpose of the PR*
Integrate the changes in the above PR into dev.
Changes*
How to check the feature
Reference