Update/from rainbo #1949
Merged
Update/from rainbo #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
n13
reviewed
Jun 11, 2024
lib/screens/authentication/import_key/interactor/usecases/import_key_use_case.dart
Outdated
Show resolved
Hide resolved
n13
reviewed
Jun 11, 2024
lib/screens/transfer/send/send_confirmation/interactor/viewmodels/send_confirmation_bloc.dart
Show resolved
Hide resolved
n13
reviewed
Jun 11, 2024
lib/screens/transfer/send/send_enter_data/interactor/mappers/send_amount_change_mapper.dart
Show resolved
Hide resolved
n13
reviewed
Jun 11, 2024
lib/screens/wallet/components/tokens_cards/interactor/mappers/token_balances_state_mapper.dart
Show resolved
Hide resolved
n13
requested changes
Jun 11, 2024
n13
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
A few things for later
-
New architecture for tokens with an infinite token list for the user to manually choose from Streamline blockchain API calls #1951
-
rename blocktransfer to isTransferAllowed
-
rename transactionModel to TransferActionModel
-
replace plain try/catch with validation validate added #1956
-
Possibly remove static precisions table?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗃 Catch up with multitoken features and bugfixes in rainbow apk version
Multitoken support using the tokensmaster contract was almost complete when master branch development was frozen at v2.9.2. A Hypha policy for curating tokens to appear in the wallet was adopted in late 2022 https://dao.hypha.earth/hypha/agreements/36006 .
The side-loadable "Light Wallet Rainbow Edition" continued the multitoken development in the rainbow_apk branch and received limited field use. From this experience a number of bug fixes and refinements were made. Several refinements support specific features of the Rainbow Token contract https://github.com/JoinSEEDS/seeds-smart-contracts/blob/master/src/seeds.rainbows.cpp e.g. negative balances. Refer to the commit list for details.
Localscale Wallet is based on a fork of the rainbow_apk branch and has received considerable field use as well, providing additional confidence. Localscale has a mutual-support MOU with Hypha.
Note that aeab193 makes tokens curated by Localscale visible in the Light Wallet. This should be recognized by a policy update on the Hypha DAO. https://dao.hypha.earth/hypha/agreements/65804
After merging this, we will want to set
_featureFlagTokenMasterListtrue at https://console.firebase.google.com/project/seeds-77371/config/env/firebase . However activating the feature results in a burst of API calls at app startup which stresses things: #1950✅ Checklist
🕵️♂️ Notes for Code Reviewer
Technical explanations to help your peers review your work - including environments, credentials, etc.
🙈 Screenshots
For all UI changes
👯♀️ Paired with
@github-handle or "nobody" if you did not pair.