-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rainbow token contract update #460
base: master
Are you sure you want to change the base?
Conversation
include/seeds.rainbows.hpp
Outdated
* | ||
* @param owner - the account containing tokens to retire, | ||
* @param quantity - the quantity of tokens to retire, | ||
* @param burn - if true, staked tokens are left in escrow, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... I don't understand what burn parameter does. You'd think it burns token if this is true. But.... that's not what it does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The retire
action on an ordinary token would just burn it, basically destroying value. But with "staked" or "backed" tokens, a retire
action releases the staked value to the token holder and is more of a conversion of value. By setting the burn flag, a staked token is retired (value destroyed) but the staked value remains in escrow and is not released. Burn flag is a NOP on a plain token with no backing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can call it force_burn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or... do_not_redeem?
Hmm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redeem_for_backing == true -> (burn == false)
? maybe describe the inverse, the positive ... so if the flag is true, the token holder receives the backing token for their retired tokens
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"burn" flag is now "do_redeem" with inverted logic.
…tracts into JoinSEEDS-master
merge from master
Bugfix, minor feature add (enable burning tokens without releasing staked resources), tests.
Also replaced "staking" terminology throughout with "backing".
Added "pay to play" fee for issuer to create token (100 SEEDS); old behavior (issuer pays RAM) available with #ifdef