Skip to content

Commit

Permalink
Merge #1617: Document Core wallet creation for v26
Browse files Browse the repository at this point in the history
79e5c3d Document Core wallet creation for v26 (Kristaps Kaupe)

Pull request description:

  Creation of legacy (BDB) wallet have been deprecated with Bitcoin Core 26.0 release. Proper solution is to [implement descriptor wallet support](#1571), but for now let's update documentation.

  Also we can't update tests to v26 because of this (we could in theory, but it's unnecessary complexity to maintain two different `bitcoin.conf`'s for different Core versions just because of tests).

Top commit has no ACKs.

Tree-SHA512: 90b6479f21ea7131f080a67aab122970b5ed097fa261ad9a5e4d05aa207c77722a2790d0ce317d8c746e395c421e456b992161d81168cbc758951cb57e8bde2f
  • Loading branch information
kristapsk committed Dec 9, 2023
2 parents 98466ea + 79e5c3d commit 920a001
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docs/USAGE.md
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ If this command fails with error `Unknown named parameter descriptors`, it means
bitcoin-cli createwallet "jm_wallet"
```

If this command fails with error `BDB wallet creation is deprecated and will be removed in a future release. In this release it can be re-enabled temporarily with the -deprecatedrpc=create_bdb setting.`, it means you run Bitcoin Core version v26 or newer. In that case you must add `deprecatedrpc=create_bdb` setting to your `bitcoin.conf`, restart Bitcoin Core and try again.

The "jm_wallet" name is just an example. You can set any name. Alternative to this `bitcoin-cli` command: you can set a line with `wallet=..` in your
`bitcoin.conf` before starting Core (see the Bitcoin Core documentation for details). At the moment, only legacy wallets (`descriptors=false`)
work with Joinmarket. This means that Bitcoin Core needs to have been built with legacy wallet (Berkeley DB) support.
Expand Down

0 comments on commit 920a001

Please sign in to comment.