Fix Reputation Mining Cycle Handler Timestamp #296
+59
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdig
force-pushed
the
fix/correct-reputation-cycle-timestamp
branch
from
4c90671 to
f586af3
Compare
iamsamgibbs
approved these changes
Dec 4, 2024
jakubcolony
approved these changes
Dec 4, 2024
bassgeta
approved these changes
Dec 5, 2024
|
@bassgeta can I get the "corresponding" review on the CDapp side too please :) |
|
This is on hold until the may deployment goes out, will merge after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the timestamp value for the
reputationMiningCyclehandler, since if the ingestor falls behind the chain, by the time it catches back up to this event it will have used the wrong timestamp for reputation, meaning both updates and UI reporting will be wrong.This value is mostly used for UI display purposes, however, even so, if it gets out of date, users might get the wrong impression when looking up the reputation cycle's next update in the user hub