Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DlgPrefController layout fixes #3

Open
wants to merge 7 commits into
base: controller_pref_tab_layout
Choose a base branch
from

Conversation

ronso0
Copy link

@ronso0 ronso0 commented Jan 27, 2025

No description provided.

@ronso0
Copy link
Author

ronso0 commented Jan 27, 2025

Note that keepng the device info minimal was the only way to avoid random device/mapping info layout changes when going through the mapping list. I understand the horizontal 50/50 split for these groupboxes would be nice but I didn't find a way to set such a ratio and at the same time a) keep the layout static and b) give both groupboxes the space they need.
(actually 40/60 device strings don't seem to be long, but mapping descriptions can use more space)

Hope you agree with the removal of "handling".

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13000033798

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 31.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/dlgprefcontroller.cpp 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/controllers/dlgprefcontroller.cpp 2 0.0%
Totals Coverage Status
Change from base Build 12553291147: 0.0%
Covered Lines: 33336
Relevant Lines: 104828

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants