William's assignments #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With help from @skreem
| " \"s1\",\n", | ||
| " [\"s6\", \"s7\"])\n", | ||
| "\n", | ||
| "# TODO: tests go here\n", |
There was a problem hiding this comment.
One of my email addresses is [email protected], and it looks like your regex won't take [email protected]. Also, your state machine is a little more complicated than it needs to be: why do s11 and s12 exist? It seems like the state where we're waiting for either an @ or a x can just be s2, and it can self-loop on seeing an x. Similarly, s4 can self-loop on seeing more letters. I was able to do it with 7 states, of which 1 was accepting. Might be good to try for that!
I found it easiest to write the string recognizer as a regular expression, then manually build a state machine that realized it.
chern
changed the title
Started two months ago and never finished (whoops!), but I’ll commit this before I forget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.