Assignments from Neil #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good! A code cell would be nice in the "hello-world" notebook though, to sanity-check the environment. |
|
@JoeOsborn How is a6db5b4 |
…future merge issues
|
@JoeOsborn Got the switch A* working as far as I can tell (assignment 2) Edit: Not anymore |
|
@skreem: Epic. |
| " #new_cost = cost_so_far[current] + 1\n", | ||
| " new_cost = current.cost + 1\n", | ||
| " \n", | ||
| " if not successor in visited or new_cost < current.cost:\n", |
There was a problem hiding this comment.
This or isn't quite right, and turns this into if not in visited or false since (current.cost+1) is never less than current.cost. You want to compare against the cost of the member of visited which is equivalent to successor. This could lead to finding suboptimal paths since the node equivalent to successor may be tagged with a higher cost but never replaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.