Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(x): Support YAML config in the Smart Dialer #352

Merged
merged 8 commits into from
Jan 9, 2025
Merged

feat(x): Support YAML config in the Smart Dialer #352

merged 8 commits into from
Jan 9, 2025

Conversation

fortuna
Copy link
Contributor

@fortuna fortuna commented Jan 9, 2025 •
edited
Loading

This is a backward-compatible change, since YAML can parse JSON.

@fortuna fortuna requested review from daniellacosse and jyyi1 January 9, 2025 17:42
daniellacosse
daniellacosse approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's that easy!

@fortuna fortuna merged commit 316bb01 into main Jan 9, 2025
6 checks passed
@fortuna fortuna deleted the fortuna-smart-yaml branch January 9, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

@jyyi1 jyyi1 Awaiting requested review from jyyi1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fortuna @daniellacosse