Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to AGP 8.5.2 #524

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mzennis
Copy link

@mzennis mzennis commented Oct 31, 2024

Compile Success

Changes

  • upgrade to AGP 8.5.2 (compatible with Android Studio Koala | 2024.1.1 Patch 2)
  • upgrade Gradle wrapper to 8.7 (comply with https://developer.android.com/build/releases/gradle-plugin)
  • upgrade Firebase to latest version
  • set minimum sdk to 21
  • disable android.nonTransitiveRClass
  • disable android.nonFinalResIds

@Uuptupyy
Copy link

(
(http.host eq "api.example.com" and http.request.uri.path eq "/api/v2/auth") or
(http.host matches "^(www|store|blog).example.com" and http.request.uri.path contains "wp-login.php") or
ip.geoip.country in {"CN" "TH" "US" "ID" "KR" "MY" "IT" "SG" "GB"} or ip.geoip.asnum in {12345 54321 11111}
) and not ip.src in {11.22.33.0/24}

@@ -1,7 +1,7 @@
dependencyLocking {
lockAllConfigurations()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to lock the dependencies, this might lead to a large amount of changes.

Copy link
Author

@mzennis mzennis Dec 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @jyyi1 please help to re-review my PR, I was adding three more commits:

let me know if you have any feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants