Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow bypass when vpn is lockdown #420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ignoramous
Copy link
Contributor

Allowing network bypass on a vpn that's running in lockdown mode
causes it to lose internet connectivity. Prevent the vpn from entering
such a state at least on vpn-start / vpn-restart.

Allowing network bypass on a vpn that's running in lockdown mode
causes it to lose internet connectivity. Prevent the vpn from entering
such a state at least on vpn-start / vpn-restart.
@ignoramous
Copy link
Contributor Author

ignoramous commented Sep 29, 2021

A slightly better implementation would check for vpn lockdown on every network_change event, and restart the vpn to disallow / allowBypass accordingly. Android doesn't broadcast change in vpn's lockdown mode, and so even checking on every network_change event doesn't cover all cases either. In RethinkDNS (an intra fork), we check for vpn lockdown mode changes on every new tcp/udp conn (wasteful, but... 🤷)

https://github.com/celzero/rethink-app/blob/46f08da505e234c098626208682f2b12dce21920/app/src/main/java/com/celzero/bravedns/service/BraveVPNService.kt#L1103-L1117

Prior art: #24 (comment)

Ref: celzero/rethink-app#92

@Nxxmn
Copy link

Nxxmn commented Jul 22, 2022

gh pr checkout 420

3 similar comments
@Nxxmn
Copy link

Nxxmn commented Jul 22, 2022

#24 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants