Compat: Fix compat tests for depthOrArrayLayers restrictions

textureBindingViewDimension = '2d' must have depthOrArrayLayers = 1 textureBindingViewDimension = 'cube' must have depthOrArrayLayers = 6
Jiawei-Shao · Dec 4, 2023 · 6590a34 · 6590a34
1 parent eb48ff8
commit 6590a34
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/webgpu/compat/api/validation/createBindGroup.spec.ts b/src/webgpu/compat/api/validation/createBindGroup.spec.ts
@@ -68,6 +68,8 @@ function isValidViewDimensionForDepthOrArrayLayers(
   depthOrArrayLayers: number
 ) {
   switch (viewDimension) {
+    case '2d':
+      return depthOrArrayLayers === 1;
     case 'cube':
       return depthOrArrayLayers === 6;
     case 'cube-array':

diff --git a/src/webgpu/compat/api/validation/texture/createTexture.spec.ts b/src/webgpu/compat/api/validation/texture/createTexture.spec.ts
@@ -55,12 +55,13 @@ g.test('invalidTextureBindingViewDimension')
   )
   .fn(t => {
     const { dimension, textureBindingViewDimension } = t.params;
+    const depthOrArrayLayers = textureBindingViewDimension === '1d' || textureBindingViewDimension === '2d' ? 1 : 6;
     const shouldError = getTextureDimensionFromView(textureBindingViewDimension) !== dimension;
     t.expectGPUError(
       'validation',
       () => {
         const texture = t.device.createTexture({
-          size: [1, 1, dimension === '1d' ? 1 : 6],
+          size: [1, 1, depthOrArrayLayers],
           format: 'rgba8unorm',
           usage: GPUTextureUsage.TEXTURE_BINDING,
           dimension,