In MetalRedrawer, stop delaying rendering as soon as the window becomes non-occluded. #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijah-semyonov
requested changes
Nov 7, 2023
elijah-semyonov
approved these changes
Nov 7, 2023
igordmn
approved these changes
Nov 7, 2023
MatkovIvan
reviewed
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, when the window is just getting show,
isOccludedwill returntruewhile we're already trying to draw into it. This causesMetalRedrawer.drawto delay for 300ms in order to avoid wasting resources drawing while the window is occluded. But because this delay is not interrupted even when the window becomes non-occluded, we get a delay drawing the 2nd frame.This PR adds a call from native code
NSWindowDidChangeOcclusionStateNotificationthat interrupts the delay when the window becomes non-occluded, so that drawing can resume immediately.