Fix SVGLength.withUnit #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e input and not `this.unit`
igordmn
approved these changes
Sep 27, 2023
|
Mering it now. The failing CI/ios is attempted to be fixed separately here - #805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create a new SVGLength with a
_unitfrom the input and notthis.unitIt seems that this typo didn't cause any real issue so far.
The only it was used in compose is here: https://github.com/JetBrains/compose-multiplatform-core/blob/bcaacc85477f959cac171b60258679b6244f512b/compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/res/DesktopSvgResources.desktop.kt#L66
But here
withUnitdoes nothing really useful, sincewithUnitdoesn't do any conversion of thevalue- it preserves the originalvalue.