Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename file name to adequately describes the content (Recent Edits) #29

Merged
merged 13 commits into from
May 5, 2021

Conversation

sun-flat-yamada
Copy link
Contributor

@sun-flat-yamada sun-flat-yamada commented May 4, 2021

Summary

  • Rename file name to adequately describes the content.
  • The following workshop contents are not "Recently changed files" but "Recent edits", so I renamed the files appropriately.
01-Navigation\3-Navigate_to_somewhere_youve_already_been\3.3-Recently_changed_files.cs
  -> 3.3-Recent_edits.cs

This topic is touched upon in the following discussion:

#28 (comment)

Issue

#30
Incorrect file name for "Recent Edits" workshop

#20
Proposal for creating a Japanese localized version

How did I test it?

  • I have only conducted self-verification using a translation tool.
  • If you have a reliable Japanese person, I would like to ask for a third-party review.

Good days!

@maartenba
Copy link
Contributor

@sun-flat-yamada Would you mind making the change in the English version, too? That way we keep things consistent from the start.

@sun-flat-yamada
Copy link
Contributor Author

@ sun-flat-yamada英語版も変更していただけませんか。そうすれば、最初から一貫性を保つことができます。

Hi, @maartenba .

OK, of course. I'll set up an Issue and tie this PR to it.
I should have started an Issue first. I'm sorry about that.

Here is an issue :
#30

I will update this PR (and I'll update English version soon).

@sun-flat-yamada
Copy link
Contributor Author

@maartenba , I'm done.
Could you please check?

@maartenba
Copy link
Contributor

Thanks @sun-flat-yamada !

@maartenba maartenba merged commit db47c3e into JetBrains:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants