Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect file name for "Recent Edits" workshop #30

Open
sun-flat-yamada opened this issue May 5, 2021 · 9 comments
Open

Incorrect file name for "Recent Edits" workshop #30

sun-flat-yamada opened this issue May 5, 2021 · 9 comments

Comments

@sun-flat-yamada
Copy link
Contributor

sun-flat-yamada commented May 5, 2021

Summary

  • The following workshop contents are not "Recently changed files" but "Recent edits".
  • Because, I propose to rename the files appropriately.
01-Navigation\3-Navigate_to_somewhere_youve_already_been\3.3-Recently_changed_files.cs
  -> 3.3-Recent_edits.cs

This topic is touched upon in the following discussion:

#28 (comment)

Target scope

  • English and Japanese (All currently available language versions)

NOTE

@maartenba

@sun-flat-yamada
Copy link
Contributor Author

Hi, @maartenba .

I have a consultation.

I refer to the cheat sheet of shortcuts to make sure it works before I translate.

However, I'm noticing a few issues that concern me. Since the shortcuts are so diverse, perhaps yours as JetBrains have set a policy on what to include in the cheat sheet.

Is there an appropriate place to discuss this issue?

For examples :

  • Some of the feature names are different between ReSharper and Rider
  • Some of the features listed in the Workshop are not listed in the cheat sheet (ex. Recent Location : Ctrl+Shift+E)

I'm looking at the following cheat sheets:

  • Rider Default IntelliJ keymap ex. "Recent Locations - Ctrl+Shift+E" in the workshop is not listed. It looks like a simple missing error to me.
  • Rider ReSharper keymap The "Recent Locations" feature is listed here but name is different from "Recently changes files - Ctrl+Shift+,".
  • ReSharper VisualStudio keymap "Recent Locations" feature is listed here but name is different from "View recent edits - Ctrl+Shift+,".

@maartenba
Copy link
Contributor

@khalidabuhakmeh Which ones did you use last time you added them? Was it based on R# or on Rider?

@khalidabuhakmeh
Copy link
Contributor

khalidabuhakmeh commented May 5, 2021

I've been using the Visual Studio keymaps as a default, but I am on macOS so I'm using the Rider keyboard shortcuts. Like @sun-flat-yamada points out, and we've discussed, keymaps and shortcut keys are hard to put in the documentation.

@maartenba
Copy link
Contributor

Does that help @sun-flat-yamada ? R# VS keymap seems to be leading.

@sun-flat-yamada
Copy link
Contributor Author

@maartenba , Thanks for inviting @khalidabuhakmeh to this discussion.

But, Umm... I think we are missing the point a little.
If I were to write my expectations in concrete terms, they would be as follows :

  • I want to improve my cheat sheet.
    • to unify the names of the same functions.
    • to fix what I think is a mistake.

Is there a place where we can discuss and improve?

@khalidabuhakmeh
Copy link
Contributor

Maybe we can start an issue for each point and tackle them independently. It will also help keep the work isolated from each other.

@maartenba
Copy link
Contributor

Perhaps a bit of history will help, too. This repository was created with R# in mind, and later, we tacked on Rider. When Rider came about, that was easy to add: every R# feature exposed in Rider back then was the same.

Since, features have been polished a bit to fit the Rider philosophy better. So while many features are identical, sometimes they indeed have another name, or they work slightly different in each product.

I think unifying makes sense, and where there are differences in naming, I think it's fine to use the action name for the specific product. When there's difference in functionality, a comment about that should help as well.

@sun-flat-yamada
Copy link
Contributor Author

Thank you, @maartenba and @khalidabuhakmeh , for your input.

I'd like to start a discussion, but I don't think this repository is the right place for it.

I believe that what we are about to discuss will be a valuable asset that should be shared with others later on.
Therefore, I think it would be more appropriate to discuss it in the R# or Rider issue management repository.

For this reason, I would like to move the discussion to such a place, if such a place exists (R#/Rider's Cheat Sheet repository).
If it doesn't exist, I think it would be better to create it, but if it takes a lot of time, I think it's possible to work on this repository as an alternative.

Do you expect to discuss the topic of R#/Rider Cheat Sheet in this Workshop repository?

@maartenba
Copy link
Contributor

Let me loop you in via e-mail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants