-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing 'limit' and 'offset' parameters #368
Comments
…etUnassignedAsync (cherry picked from commit 25b000c)
I'm having second thoughts about adding limit and offset to the IpAddresses.GetUnassignedAsync method because GetAssignedAsync does not allow limit/offset and I think it makes sense for the signature of these two methods to be consistent. |
Adding {
"errors": [
{
"field":"offset",
"message":"unknown field"
}
]
} Therefore, I will not be adding offset to this method. |
…ync in order to be consistent with the signature of the GetAssignedAsync method
…ync in order to be consistent with the signature of the GetAssignedAsync method
🎉 This issue has been resolved in version 0.85.0 🎉 The release is available on: Your GitReleaseManager bot 📦🚀 |
In the process of implementing the changes for #361 and #367, it occurred to me that some methods don't support the 'limit' and 'offset' parameters which are necessary for paging. This seems to have been added to the SendGrid API some time ago but there was no announcement or mention of this in SendGrid's release notes. This explains why some methods in the StrongGrid library, such as
ApiKeys.GetAllAsync
for example, currently do not support paging.I will update the following list of methods that are missing the 'limit' and 'offset' parameters:
limit
parameter but not theoffset
. That's very odd and I am assuming it's simply an error in the documentation.GellAllAsync
and filter the result in order to find 'unassigned' addresses. This means that page number 2 of unassigned addresses does not necessarily correspond to page number 2 of all addresses. I need to think about how I will resolve this issue.AccessManagement.GetAccessHistoryAsync . This is another case where SendGrid's documentation talks about theUPDATE January 2022: SendGrid throws "unknown field" exception when adding "offset" to the requestlimit
parameter but not theoffset
. Again, I'm assuming it's simply an error in the documentation.EmailActivities.SearchAsync. Another case where SendGrid's documentation talks about theUPDATE January 2022: I am not able to test this change because my account is not signed up for the Email Activities API. Therefore I am not going to make any change to this functionality.limit
parameter but not theoffset
.The text was updated successfully, but these errors were encountered: