Skip to content

Commit

Permalink
Improve comment to explain why the seemingly redundant "NET5_0" is ne…
Browse files Browse the repository at this point in the history
…cessary and when it will be safe to remove it
  • Loading branch information
Jericho committed Apr 14, 2021
1 parent 2986b2a commit 0af4aea
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions Source/StrongGrid/WebhookParser.cs
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,11 @@ We can get rid of the code that relies on ECDsaCng and remove reference to
We can get rid of the 'ConvertECDSASignature' class and the Utils methods that
convert public keys when we stop suporting .NET framework and .NET standard.
NET5_0_OR_GREATER works fine on Windows but doesn't work on Ubuntu. That's I
added the seemingly redundant "NET5_0" in the conditional block below.
NET5_0_OR_GREATER was added to the NET SDK very recently and works fine on
AppVeyor's Windows image which runs NET SDK 5.0.201. However, it doesn't work
on their Ubuntu image because it's still on NET SDK 5.0.101. That's why I added
the seemingly redundant "NET5_0" in the conditional block below. It will be safe
to remove it when the SDK in AppVeyor's Ubuntu image is upgraded.
Note:
ECDsa is cross-platform and can be used on Windows and Linux/Ubuntu.
Expand Down

0 comments on commit 0af4aea

Please sign in to comment.