Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fromBytesDelimited to avoid confusion #32

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

Ostrzyciel
Copy link
Member

No description provided.

The two new methods should be useful when dealing with reactive streams of bytes, as opposed to Java IO streams.
It would require the input byte arrays to contain exactly one stream frame, which is hard in practice. I'm not sure how to implement it with ByteStrings (I assume it's possible), I'd have to dive much deeper into the protobuf library than I'd like to.
@Ostrzyciel Ostrzyciel merged commit d3c7217 into main Sep 21, 2023
2 checks passed
@Ostrzyciel Ostrzyciel deleted the io-delimited-helpers branch September 21, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant