Jena CLI: allow changing writer settings with presets #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was not really possible to change the Jelly writer options when using the Jena CLI utilities. There is a CLI option to modify the Jena context, but our context would have to be set to a Java object... which I honestly hope is not possible, because that would be RCE or something. So, to get around this, this commit introduces "presets" based on the default setting presets available in JellyOptions. The user can simply choose one of these by setting a symbol to the name of the preset. I've added a test that checks if this works across all writers. I've also added a doc page documenting this, because honestly, it's a neat and useful feature.
|
I'll review and merge it tomorrow. Sleep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was not really possible to change the Jelly writer options when using the Jena CLI utilities. There is a CLI option to modify the Jena context, but our context would have to be set to a Java object... which I honestly hope is not possible, because that would be RCE or something.
So, to get around this, this commit introduces "presets" based on the default setting presets available in JellyOptions. The user can simply choose one of these by setting a symbol to the name of the preset.
I've added a test that checks if this works across all writers.
I've also added a doc page documenting this, because honestly, it's a neat and useful feature.