Fix missing physical stream type in Jena stream writer #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've also added a bunch of tests to improve the coverage on the writer code in the various rarely used code paths. Issue: #218
This is done in RDF4J writer and in the "classic" Jena writers, so we should do it too. I've added a test that fails without the new addition.
Ostrzyciel
deleted the
218-jena-riot-stream-writer-does-not-set-physical-stream-type
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added a bunch of tests to improve the coverage on the writer code in the various rarely used code paths.
Issue: #218