Add an IRI cache to NodeDecoder #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, rewrite it in Java. As usual, if it works, I will finish the docstrings etc. This is a very simple cache that assumes that a name entry is most likely used only with one prefix entry. Therefore, the last IRI constructed from prefix+name is cached here. There is a mechanism for dependent cache invalidation very similar to what we have in NodeEncoder (with serial numbers). Let's see.
Ostrzyciel
added a commit
that referenced
this pull request
Oct 26, 2024
Continuation of #201 Fixed the code to avoid doing casting on runtime – this was compiling into additional JVM instructions. Now, we don't have any casts in the code after compilation. Also: add javadocs.
Ostrzyciel
added a commit
that referenced
this pull request
Oct 26, 2024
* Polish the new NameDecoder implementation Continuation of #201 Fixed the code to avoid doing casting on runtime – this was compiling into additional JVM instructions. Now, we don't have any casts in the code after compilation. Also: add javadocs. * DRY up the code * Oops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, rewrite it in Java.
As usual, if it works, I will finish the docstrings etc.
This is a very simple cache that assumes that a name entry is most likely used only with one prefix entry. Therefore, the last IRI constructed from prefix+name is cached here. There is a mechanism for dependent cache invalidation very similar to what we have in NodeEncoder (with serial numbers).
Let's see.