Skip to content

Commit

Permalink
Remove dependency on full Netty
Browse files Browse the repository at this point in the history
The dependency was not needed, because grpc-netty-shaded already provides what we need: grpc/grpc-java#10931

This also helps avoid any future vulnerabilities, because Netty is quite prone to these.

Note that this is not a breaking change, because we weren't distributing any "real" packages with this dependency.
  • Loading branch information
Ostrzyciel committed Nov 13, 2024
1 parent f444dcb commit 6c60f6d
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions build.sbt
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ lazy val protobufCompilerDeps = Seq(
"com.thesamet.scalapb" %% "scalapb-runtime" % scalapbV % "protobuf",
"com.thesamet.scalapb" %% "scalapb-runtime-grpc" % scalapbV,
"com.google.protobuf" % "protobuf-java" % protobufV,
"io.grpc" % "grpc-netty" % scalapb.compiler.Version.grpcJavaVersion,
)

lazy val commonSettings = Seq(
Expand All @@ -63,7 +62,6 @@ lazy val commonSettings = Seq(
assemblyJarName := s"${name.value}.jar",
assemblyMergeStrategy := {
case x if x.endsWith("module-info.class") => MergeStrategy.concat
case x if x.endsWith("io.netty.versions.properties") => MergeStrategy.first
case x => assemblyMergeStrategy.value(x)
},
crossVersion := CrossVersion.binary,
Expand Down

0 comments on commit 6c60f6d

Please sign in to comment.