Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: regress hipo::bank::get to hipo::bank::get[TYPE] #31

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Dec 2, 2023

Since gavalian/hipo#29 was reverted, we are forced to regress some usability here.

Instead of using upstream type inference via

bank.get(...)

we must use one of

bank.getInt(...)
bank.getFloat(...)
// etc.

and know the data types at compile time (though the correct type is only verified upstream at runtime).

@c-dilks
Copy link
Member Author

c-dilks commented Dec 2, 2023

At least this is the more optimized approach.

@c-dilks c-dilks merged commit 4e6c314 into main Dec 2, 2023
5 checks passed
@c-dilks c-dilks deleted the regress-getters branch December 2, 2023 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant