Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CODEOWNERS file #244

Draft
wants to merge 8 commits into
base: development
Choose a base branch
from
Draft

feat: CODEOWNERS file #244

wants to merge 8 commits into from

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Apr 2, 2024

A CODEOWNERS file provides the following:

  • connects contributors to files they worked on
  • notifies contributors of proposed changes to their files, by automatically requesting them for PR review

TODO

  • generate a CODEOWNERS file
  • replace real names with GitHub handles
  • consider automating its update, e.g, with version-bump.sh let's not.. at least the "default" owners (of *) will be notified for new files

@whit2333
Copy link
Collaborator

whit2333 commented Jan 2, 2025

FWIW, you might already be aware of this useful git command. It might make sense to not bother the likes of me if I have 1 commit out of many:

$ git shortlog -n -s -e --  common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CLASDecoder4.java
    28  Nathan Baltzell <[email protected]>
     9  Raffaella De Vita <[email protected]>
     8  Gagik Gavalian <[email protected]>
     2  Nathan Baltzell <[email protected]>
     1  Veronique Ziegler <[email protected]>
     1  Whitney Armstrong <[email protected]>

Set the threshold to say 10% to not bother infrequent contributors:

commit_threshold=$(echo " $(git shortlog -n -s -e --  common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CLASDecoder4.java | cut -f 1 | paste -s -d+ - | bc ) * 0.1 " | bc)
git shortlog -n -s -e --  common-tools/clas-detector/src/main/java/org/jlab/detector/decode/CLASDecoder4.java  |  awk '$1>'${commit_threshold}' {print $0}'
    28  Nathan Baltzell <[email protected]>
     9  Raffaella De Vita <[email protected]>
     8  Gagik Gavalian <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants