Clean up JANA/Compatibility #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerror is moving out of JANA2 permanently and will live on in halld_recon as DANA/jerror.h
md5 is a vendored dependency which we'd like to keep separated from the rest of our code and internal, so that it doesn't become part of our install interface. Referencing it from a public header file unnecessarily forces us to provide it downstream.
This is so that md5 gets "baked in" to libjana.{so,a}, rather than producing a separate install artifact
Because the `jana2` object library alone doesn't contain the `VendoredMD5` symbols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md5a private dependency that lives under src/externaljerror_t, so that it can be moved into halld_recon.