-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
355 jana1 2 documentation side menu #359
Conversation
…ocumentation-side-menu
I believe it makes #356 obsolete. I saw it too late. Sorry. |
While you are working on this, it looks like https://jeffersonlab.github.io/JANA2/#/tutorial is a broken link? |
Ah... site deploys to github pages on each PR github actions run. That is not what we want. Fixed that. But the bright side is - you can see changes right now =) But we WANT to merge this PR ASAP now. |
Fixed that. Worked on local machine because file system is case tolerant. It was Tutorial.md vs tutorial.md |
If it makes your workflow faster, you can merge the documentation changes without waiting for all the other tests to complete |
I would prefer @RaiqaRasool to look at changes too. But I feel urgency to merge this PR to prevent security issue with any PR pushing changes to a website. |
So, please, make another issue or PR if something is bad here. |
I probably did something that hasn't been asked, please no offence here. But I just wanted to make it more accessible and easier to read.