Bugfix: Use-after-free when same plugin is loaded twice #343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix addresses issue #333.
It introduces some behavior changes: (!)
plugins
parameter, it only gets loaded once.plugins
parameter no longer clobbers the projects' default plugins specified viaJApplication::AddPlugin
. Rather, the project's default plugins are loaded first, and any additional user plugins specified by theplugins
parameter are loaded afterwards.jana -Pplugins=MyPlugin,other/plugin/dir/MyPlugin.so -Pjana:plugin_path=normal/plugin/dir
whereMyPlugin.so
can be found in both places. We aren't doing the users any favors by letting them get into this mess, and we are better off with a plugin loader that is easier to reason about.