Bugfix: Build system fixes #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanwbrei
force-pushed
the
nbrei_build_system_fixes
branch
from
ddbec8b to
8991bf3
Compare
Top-level 'programs' pattern was incorrectly matching against src/programs. Also made the pattern for '/build' into a wildcard so that it includes build_podio, etc.
Some examples previously installed to CMAKE_INSTALL_PREFIX/programs, which isn't in the FHS. They now install to CMAKE_INSTALL_PREFIX/bin instead.
nathanwbrei
force-pushed
the
nbrei_build_system_fixes
branch
from
8991bf3 to
8f09ea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jana-confignow adds$JANA_INSTALL_DIR/libto rpathjana-confignow understands static vs dynamic library linking.gitignoreno longer accidentally ignoressrc/programsexamples/SubeventCUDAExampleandexamples/UnitTestingExamplenow install tobininstead ofprograms.gitignorenow uses wildcards for build and install directories