Improve CI coverage #300
Merged
Improve CI coverage #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of a redundant copy of catch.hpp and establishes a convention for what to do with vendored libraries
We want to keep this around as an example of how to work with TObject DSTs. It doesn't belong in plugins/ because it isn't a generic utility, and it's old name suggested that it was a ROOT-enabled version of JTest, which it is not.
This lets us build JANA2 with -DUSE_ROOT=1, -DUSE_PODIO=1, -DUSE_ZEROMQ=1, -DUSE_PYTHON=1, -DUSE_XERCES=1.
Podio now excepts if you try to add an immutable object to a non-subset collection. The collection id is now part of the immutability contract!
Inspired by the failing Podio test cases
Luckily, this ended up being a feature that we didn't need, and I won't particularly miss. It is another small push towards getting rid of JFactoryPodioT completely...
nathanwbrei
force-pushed
the
nbrei_improve_ci
branch
from
a77d220 to
40376ef
Compare
nathanwbrei
force-pushed
the
nbrei_improve_ci
branch
from
aca7bdc to
381c76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI wasn't running tests with USE_PODIO=1, etc.